Add Faker::Internet.uuid #1603
Merged
Add Faker::Internet.uuid #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
suggested changes
May 2, 2019
lib/faker/default/internet.rb
Outdated
| @@ -192,6 +192,10 @@ def user_agent(vendor = nil) | |||
| sample(agents) | |||
| end | |||
|
|
|||
| def uuid | |||
| Faker::Config.random.bytes(16).unpack('H8H4H4H4H12').join('-') | |||
There was a problem hiding this comment.
probably best to generate a valid version4 UUID incase there's a library out there that does something special based on the version. For Faker's purposes, that just means that we need to make sure the first digit in the 3rd block is always a 4:
xxxxxxxx-xxxx-4xxx-xxxx-xxxxxxxxxxxx
|
🎊 |
Zeragamba
approved these changes
May 8, 2019
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Add Faker::Internet.uuid * Make uuid v4 compatible
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add Faker::Internet.uuid * Make uuid v4 compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUIDs are incredibly common. Many databases, APIs, etc will use them to identify resources. Being able to generate these easily is paramount to having a productive development environment.
So, why not just use
SecureRandom.uuid?The beauty of faker is that is can be used to generate deterministic sequences of numbers in a non-deterministic world. This makes debugging much easier, as we have one less thing to reason about.
This patch uses fakers PRNG to build a UUID, which solves this problem.
supersedes #943