Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue url in PULL_REQUEST_TEMPLATE #1690

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Update issue url in PULL_REQUEST_TEMPLATE #1690

merged 1 commit into from
Aug 14, 2019

Conversation

bugtender
Copy link
Contributor

Hi, everyone 👋

Just a minor update in PULL_REQUEST_TEMPLATE.md.
I think it looks better for contributors who don't know #1645

from

https://github.com/stympy/faker/issues/XXX

to

https://github.com/faker-ruby/faker/issues/XXX

Zeragamba
Zeragamba approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we forgot a few when the move was done

bpleslie
bpleslie approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@vbrazo vbrazo merged commit 6d9ef88 into faker-ruby:master Aug 14, 2019
@bugtender bugtender deleted the update-issue-url-in-pr-template branch August 14, 2019 21:04
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@bugtender @michebble
Update issue url in PULL_REQUEST_TEMPLATE (faker-ruby#1690)
d63a81d
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@bugtender @vbrazo
Update issue url in PULL_REQUEST_TEMPLATE (faker-ruby#1690)
0fee047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpleslie bpleslie bpleslie approved these changes

@Zeragamba Zeragamba Zeragamba approved these changes

@vbrazo vbrazo vbrazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugtender @vbrazo @Zeragamba @bpleslie