Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hacken 2022-11-25 High #2] Unverifiable Logic #31

Closed
zhongfu opened this issue Dec 1, 2022 · 0 comments · Fixed by #49
Closed

[Hacken 2022-11-25 High #2] Unverifiable Logic #31

zhongfu opened this issue Dec 1, 2022 · 0 comments · Fixed by #49
Labels
sev:p1 High type:enhancement Good-to-have features or fixes
Milestone
Hacken Audit 2022...

Comments

@zhongfu
Copy link
Contributor

zhongfu commented Dec 1, 2022

The Funnel contract uses the functionality of the external solmate contracts, which are out of the scope and whose description states that it is an experimental software.

Therefore, their secureness may not be guaranteed, and their usage may lead to unexpected behavior.

Path

./src/Funnel.sol : ERC20, SafeTransferLib

Recommendation

Interact only with trusted contracts, validate results after calling outer contracts.

Status

New
@zhongfu zhongfu added type:enhancement Good-to-have features or fixes sev:p1 High labels Dec 1, 2022
@zhongfu zhongfu added this to the Hacken Audit 2022-11-25 milestone Dec 1, 2022
@zlace0x zlace0x linked a pull request Dec 5, 2022 that will close this issue
Fix/audits #49
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sev:p1 High type:enhancement Good-to-have features or fixes
Projects
None yet
Milestone
Hacken Audit 2022-11-25
Development

Successfully merging a pull request may close this issue.

Fix/audits suberra/funnel-contracts
1 participant
@zhongfu