[Hacken 2022-11-25 Medium #1] Inefficient Gas Model

[zhongfu]

The Funnel smart contract imports and uses the ERC20 contract directly for the _baseToken storage variable.

The FunnelFactory smart contract imports the Funnel contract directly to use it in the initialization process.

It is best practice to use interfaces when interacting with external contracts.

Importing and using an ERC20 smart contract directly may lead to higher deployment Gas expenses when deploying new funnels.

Importing contracts directly increases the bytecode size of the deployed smart contract.

Paths

./src/Funnel.sol
./src/FunnelFactory.sol

Recommendation

Consider using the IERC20 interface for the _baseToken variable in the Funnel contract. Consider using the IFunnel interface, with an additional declaration of the initialize() function, in the FunnelFactory contract.

Status

New