[Hacken 2022-12-21 Low #04] Style Guide Violation

[zlace0x]

The project should follow the official code style guidelines.

Inside each contract, library, or interface, use the following order:

• Type declarations
• Statevariables
• Events
• Modifiers
• Functions

Path:
./src/Funnel.sol

Functions should be grouped according to their visibility and
ordered:

• constructor
• receive function (if exists)
• fallback function (if exists)
• external
• public
• internal
• private

Within a grouping, place the view and pure functions at the end.
Some contracts are not formatted correctly.

Paths:
./src/Funnel.sol
./src/FunnelFactory.sol

Solidity style guidance defines a naming convention that should be followed. Some state variables are not in the mixed case.

Path:
./src/Funnel.sol: INITIAL_CHAIN_ID, INITIAL_DOMAIN_SEPARATOR

Recommendation: The official Solidity style guidelines should be followed.

Status: Reported (There are still minor style guide violations)

[zlace0x]

Status: Wont-fix
Reason: INITIAL_CHAIN_ID, INITIAL_DOMAIN_SEPARATOR both semantically mean a constant, we adhere our style choice to their semantic meaning. Due to the use of initializer, we cannot set these variables to be a constant or immutable.