Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Fonts Support #272

Open
subframe7536 opened this issue Nov 12, 2024 · 6 comments · May be fixed by #395
Open

Google Fonts Support #272

subframe7536 opened this issue Nov 12, 2024 · 6 comments · May be fixed by #395
Labels
Futher Version Maybe will implement it in the future help wanted Cannot handle this issue and need some help

Comments

@subframe7536
Copy link
Owner

subframe7536 commented Nov 12, 2024 •
edited
Loading

I plan to upload this font to Google Fonts in next major version.

I'm using Fontlab, and its generated .glyphs / .glyphspackage will emit error while building using fontmake

fontmake: Error: In 'source\\MapleMono[wght].glyphspackage' -> 'master_ufo\\MapleMono.designspace': Compiling UFO failed: mark anchor cannot be numbered: '_t.uni031B_2'

My command:

fontmake -g ./source/MapleMono[wght].glyphspackage --keep-overlap

Seems related issue: googlefonts/fontmake#1104
@subframe7536 subframe7536 added the help wanted Cannot handle this issue and need some help label Nov 12, 2024
@subframe7536 subframe7536 changed the title Build font from .glyphs / .glyphspackage Upload to google font, build font from .glyphs / .glyphspackage Dec 6, 2024
@subframe7536
Copy link
Owner Author

Run with fontbakery and fail on some rules.

  • family/win_ascent_and_descent: some box symbols in exceed winAscent and winDescent. I just copy them from JetBrains Mono

@subframe7536 subframe7536 mentioned this issue Jan 23, 2025
Closed
@subframe7536 subframe7536 added the Futher Version Maybe will implement it in the future label Jan 26, 2025
@subframe7536 subframe7536 changed the title Upload to google font, build font from .glyphs / .glyphspackage Google Font Support Jan 26, 2025
@subframe7536 subframe7536 pinned this issue Jan 26, 2025
@subframe7536 subframe7536 changed the title Google Font Support Google Fonts Support Jan 27, 2025
@subframe7536
Copy link
Owner Author

Find out how to fix the broken fontmake build: migrate correct anchors from JetBrains Mono.

@mogeko
Copy link

mogeko commented Mar 21, 2025

I'm glad to see progress on this issue!

I'm just curious which version of Maple Mono will be uploaded to Google Fonts? Maple Mono or Maple Mono CN?

@subframe7536
Copy link
Owner Author

Indeed, I'm not sure, but I don't think the CN part is a good font due to its glyph quality.

@subframe7536
Copy link
Owner Author

google/fonts#9244

@subframe7536 subframe7536 linked a pull request Mar 22, 2025 that will close this issue
Draft
@mogeko
Copy link

mogeko commented Mar 22, 2025

I really admire your pursuit of aesthetics!

However, in reality, there has been a long-term lack of a monospaced Chinese font that is friendly to use on Google Fonts. Even Noto Mono CJK is not available on Google Fonts.💔

It would be perfect if both Maple Mono and Maple Mono CN could be provided.

@subframe7536 subframe7536 unpinned this issue Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Futher Version Maybe will implement it in the future help wanted Cannot handle this issue and need some help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Google Fonts support subframe7536/maple-font
2 participants
@mogeko @subframe7536