[JavaScript] Syntax highlighting issue with object methods

[amalk]

Stable Build 3114

Same method body loses highlighting when nested too deep.

[FichteFoll]

Please also provide the code snippets for easier reproduction (though copy'n'paste).

[amalk]

Right. The last level in this code loses the highlighting:

    function foo() {
        TweenLite.to(el, 1, {
            onComplete: function() {
                TweenLite.to(el, 1, {
                    onComplete: function() {
                        TweenLite.to(el, 1, {
                            onComplete: function() {
                                TweenLite.to(el, 1, {
                                    onComplete: function() {
                                        TweenLite.to(el, 1, {
                                            onComplete: function() {

                                            }
                                        });
                                    }
                                });
                            }
                        });
                    }
                });
            }
        });
    }

[FichteFoll]

I only start losing highlighting with this:

function foo() {
    TweenLite.to(el, 1, {
        onComplete: function() {
            TweenLite.to(el, 1, {
                onComplete: function() {
                    TweenLite.to(el, 1, {
                        onComplete: function() {
                            TweenLite.to(el, 1, {
                                onComplete: function() {
                                    TweenLite.to(el, 1, {
                                        onComplete: function() {
                                            TweenLite.to(el, 1, {
                                                onComplete: function() {
                                                    TweenLite.to(el, 1, {
                                                        onComplete: function() {
                                                            TweenLite.to(el, 1, {
                                                                onComplete: function() {
                                                                    TweenLite.to(el, 1, {
                                                                        onComplete: function() {
                                                                            TweenLite.to(el, 1, {
                                                                                onComplete: function() {
                                                                                    TweenLite.to(el, 1, {
                                                                                        onComplete: function() {
                                                                                            TweenLite.to(el, 1, {
                                                                                                onComplete: function() {
                                                                                                 TweenLite.to(el, 1, {
                                                                                                     onComplete: function() {
                                                                                                      TweenLite.to(el, 1, {
                                                                                                          onComplete: function() {
                                                                                                           TweenLite.to(el, 1, {
                                                                                                               onComplete: function() {

                                                                                                               }
                                                                                                           });     
                                                                                                          }
                                                                                                      });     
                                                                                                     }
                                                                                                 });     
                                                                                                }
                                                                                            });  
                                                                                        }
                                                                                    });  
                                                                                }
                                                                            });  
                                                                        }
                                                                    });  
                                                                }
                                                            });
                                                        }
                                                    });
                                                }
                                            });
                                        }
                                    });
                                }
                            });
                        }
                    });
                }
            });
        }
    });
}

which is a side effect of the scope name becoming to long. In the empty line, the exact scope name would be:

source.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js meta.function-call.method.js meta.group.js meta.object-literal.js meta.block.js

which is really long and code probably shouldn't be nested that deeply, which is why ST probably assumes that any scope beyond a specific length is the result of an errorneous syntax definition and stops highlighting in order not to freeze up entirely.

As a side bug report, this shouldn't be a meta.object-literal to begin with since it's a function definition (cc @wbond).

[keith-hall]

Interestingly, I lose highlighting and then seem to re-gain it.

Notice how the 1 on the inner most TweenLite.to( line is not highlighted, but the onComplete: function() { on the line afterwards is, despite being nested one level deeper by the {.

The 1 has the correct ending scope of constant.numeric.js

[FichteFoll]

Confirmed:

[wbond]

@FichteFoll I don't see where it is beginning with object-literal. It seems properly nested inside of meta.block, meta.function-call and meta.group.

[FichteFoll]

@wbond, yes you're right, the meta.object-literal scope is correct.

So I guess the only problem here is that the number 1 in line 10 does not receive the correct highlighting despite having the correct scope name?

[wbond]

Using the scope inspector, all of the scopes seem correct. The strange thing is that the 1 is colored properly with some color schemes.

I'm looking into the core code base to see what is the cause of the weirdness.

This should probably be moved over to the core issue tracker.

[wbond]

This will be fixed in dev build 3115. It was a bug in Sublime Text proper, and not the syntax.

[FichteFoll]

Confirmed fixed in 3116, by the way.