-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple versions of Language Servers files after nodejs update/change. #90
Comments
As far as node this is an |
Technically it's easy to implement a cleanup but not sure how it should work from the user's perspective. I imagine that on starting a particular server we could check whether there exist any unexpected directories in package's storage and offer to delete them by showing a dialog. Not sure I want to just automatically clean those out... |
This is also an issue if language servers are updated by the plugin maintainer / dependabot. For example, in my Package Storage there are 18 versions of pyright, 13 of bash, 6 of CSS, 4 of dockerfile, 12 of eslint, 10 of html, 22 of json, 2 of angular, 7 of typescript and 14 of yaml. This adds up to around 2 GB. |
That should not be the case. The directory structure is like |
With "update" I mean changing the version number. My Package Storage looks like this:
|
Yes, but that's the Node version number, not the server version number. So that number doesn't change when new version of LSP-pyright is released (for example). It changes when new version of Node is installed in your system (or if you are using |
I see! Misinterpreted that version number. |
Describe the bug
There are many versions of Language Servers stored in Package Storage directory. After some time total size can be larger than expected, since each of them has its own copy of dependencies (node_modules).
Based on directories names I guess that each time I update or change system nodejs version LSP installs fresh copy of Language Server.
In my case:
There are no cache/index files counted in the above.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Old versions of Language Servers should be removed on node update or after some time.
Maybe there should be setting for keeping n latest versions? Use-case might be very limited, so I don't think this is needed.
But keeping latest versions only should be an option.
Screenshots
https://i.imgur.com/yT4dFlR.png
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: