Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics proxy should be implemented as a separate command #2734

Closed
skitt opened this issue Nov 21, 2022 · 2 comments · Fixed by #2732
Closed

Metrics proxy should be implemented as a separate command #2734

skitt opened this issue Nov 21, 2022 · 2 comments · Fixed by #2732
Assignees
Labels
bug Something isn't working priority:medium

Comments

@skitt
Copy link
Member

skitt commented Nov 21, 2022

The metrics proxy is currently implemented as a direct invocation of nc:

/usr/bin/nc -v -lk -p <hostport> -e nc <nodeip> <podport>

This relies on a specific version of nc, specifically Busybox nc and its handling of -e. Alternate nettest container images based on platforms with different versions of nc handle this differently.

The proxy should be implemented as a separate command, possibly as simple as a shell script (see simpleserver), so that it can be adapted externally for different container images.

Depends on submariner-io/shipyard#1046

@skitt skitt added the bug Something isn't working label Nov 21, 2022
@stale
Copy link

stale bot commented May 20, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 20, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label May 30, 2023
@skitt skitt transferred this issue from submariner-io/submariner Jul 17, 2023
@github-actions
Copy link

@skitt skitt moved this to In Review in Submariner 0.16 Jul 17, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Submariner 0.16 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants