Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): readd docTemplate and actionTemplate to getCodeText function #194

Open
javorszky opened this issue Feb 7, 2022 · 0 comments

Comments

@javorszky
Copy link
Contributor

We've introduced golangci-lint in #188 , and one of the first linters is unparam. That one looks at function arguments to see whether they're actually needed or not. In the case of getCodeText it identified two parameters that are always being passed in as constants, so there's no reason for them to be functional parameters in the first place. As such they have been removed in commit d664574.

At some point we need to put them back though, but in order to make it useful and make the unparam happy as well, we should write unit tests for the function so we can test that it actually uses the templates correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant