You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've introduced golangci-lint in #188 , and one of the first linters is unparam. That one looks at function arguments to see whether they're actually needed or not. In the case of getCodeText it identified two parameters that are always being passed in as constants, so there's no reason for them to be functional parameters in the first place. As such they have been removed in commit d664574.
At some point we need to put them back though, but in order to make it useful and make the unparam happy as well, we should write unit tests for the function so we can test that it actually uses the templates correctly.
The text was updated successfully, but these errors were encountered:
We've introduced golangci-lint in #188 , and one of the first linters is
unparam
. That one looks at function arguments to see whether they're actually needed or not. In the case ofgetCodeText
it identified two parameters that are always being passed in as constants, so there's no reason for them to be functional parameters in the first place. As such they have been removed in commit d664574.At some point we need to put them back though, but in order to make it useful and make the unparam happy as well, we should write unit tests for the function so we can test that it actually uses the templates correctly.
The text was updated successfully, but these errors were encountered: