Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the intermittent getLatestVersion errors #305

Open
flaki opened this issue May 18, 2022 · 2 comments
Open

Hide the intermittent getLatestVersion errors #305

flaki opened this issue May 18, 2022 · 2 comments

Comments

@flaki
Copy link
Contributor

flaki commented May 18, 2022

Subo intermittently throws this notice:

ℹ️  failed to getLatestVersion: failed to fetch latest subo release: context deadline exceeded

This is due to us synchronously checking for updated subo releases and the server not responding within the deadline. We should make this check even more asynchronous, and remove this notice from production builds (it is confusing, and the user cannot really do anything about it anyway).

@jagger27 proposed to make these checks fully asynchronous and not wait for their results (but show a notice if the last check found a newer version on the next run). In these cases we can also use the failure state (now unbound from the short completion deadline) as an actual metric we collect and send back via telemetry to report potential breakage.

@arbourd
Copy link
Contributor

arbourd commented May 19, 2022

I just got one of these as well:

ℹ️  failed to getLatestVersion: failed to fetch latest subo release: GET https://api.github.com/repos/suborbital/subo/releases/latest: 403 API rate limit exceeded for 174.115.111.169. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 7m20s]

@flaki
Copy link
Contributor Author

flaki commented May 19, 2022

Yeah we should probably at least have a file that has a timestamp of last check and we don't do it more than every couple hours (that would go well with @jagger27's proposal of doing this async as you can also just serialize into the file the latest found version, which could be compared with the current version on next run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants