-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathenforce-private-props.js
85 lines (81 loc) · 2.27 KB
/
enforce-private-props.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
/**
* Copyright 2018 The Subscribe with Google Authors. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS-IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
'use strict';
module.exports = function (context) {
/**
* @param {!Array<!Node>|undefined} commentLines
* @return {boolean}
*/
function hasPrivateAnnotation(commentLines) {
if (!commentLines) {
return false;
}
return commentLines.some(function (comment) {
return comment.type == 'Block' && /@private/.test(comment.value);
});
}
/**
* @param {string}
* @return {boolean}
*/
function hasTrailingUnderscore(fnName) {
return /_$/.test(fnName);
}
/**
* @param {string}
* @return {boolean}
*/
function hasExplicitNoInline(fnName) {
return /NoInline$/.test(fnName);
}
/**
* @param {!Node}
* @return {boolean}
*/
function isThisMemberExpression(node) {
return (
node.type == 'MemberExpression' && node.object.type == 'ThisExpression'
);
}
return {
MethodDefinition: function (node) {
if (
hasPrivateAnnotation(node.leadingComments) &&
!hasExplicitNoInline(node.key.name) &&
!hasTrailingUnderscore(node.key.name)
) {
context.report(
node,
'Method marked as private but has no trailing underscore.'
);
}
},
AssignmentExpression: function (node) {
if (
node.parent.type == 'ExpressionStatement' &&
hasPrivateAnnotation(node.parent.leadingComments) &&
isThisMemberExpression(node.left) &&
!hasExplicitNoInline(node.left.property.name) &&
!hasTrailingUnderscore(node.left.property.name)
) {
context.report(
node,
'Property marked as private but has no trailing underscore.'
);
}
},
};
};