forked from subspacecloud/subspace
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: Absolute path on assets and links #195
Comments
Okey so I was going on making a PR but found that other than the template strings, the Golang files also redirects pages with absolute path... Gotta find a workaround for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If the subspace instance is running behind a reverse proxy under a subdirectory, such as
https://example.org/subspace/
, the application will attempt to source the static assets fromhttps://example.org/static/...
instead ofhttps://example.org/subspace/static/...
, links and buttons will also goes to the root directory(https://example.org/logout
) as well.This is due to the hard coded absolute path inside the web templates, and can be rectified by prepending the
SUBSPACE_BACKLINK
variable value back into the web template.Note: The current "Subspace" text, which sits next to the home icon on the navigation bar, is a great example demonstrating the hard coded absolute path issue.
Proposed solution
Referencing to this line:
subspace/web/templates/header.html
Line 25 in 32fd13b
And also these lines with absolute path issues:
subspace/web/templates/header.html
Lines 8 to 18 in 32fd13b
It can be resolved by simply prepending the backlink template variable, for example
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The assets and navigation links/buttons should be prepended with the backlink variable value.
Screenshots
Additional context
Sorry that I don't have time to make a PR at the very moment. However, if this issue isn't getting a fix within a week, I might squeeze some time to fix it.
The text was updated successfully, but these errors were encountered: