Change module caching behavior in prelude.js #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
|
Thanks for the patch! I added a test and only had to modify the alias test slightly for some reason, but in a way that didn't seem important. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that browserify manages the module caching slightly different compared to nodejs. nodejs provides a
cache-object attached torequire()as described here. Thus a module can decide to reload another module.In order to write modules that run in both environments browserify should do it like node.
As you can see in the attached code it's not necessary to change a lot. Unfortunately I couldn't find a place to write tests for it, but it seems like it doesn't break the old tests.