Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bool flag nullOnFailure in Cast Expression #185

Closed
ZJie1 opened this issue May 5, 2022 · 5 comments
Closed

Add bool flag nullOnFailure in Cast Expression #185

ZJie1 opened this issue May 5, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@ZJie1
Copy link
Contributor

ZJie1 commented May 5, 2022

In velox, there have a bool flag nullOnFailure which prevents throws and instead returns null on cast failure
Is there any plan that we add such flag in substrait?
@ZJie1 ZJie1 mentioned this issue May 5, 2022
Closed
@mbasmanova mbasmanova added the enhancement New feature or request label May 5, 2022
@mbasmanova
Copy link

CC: @mbasmanova

@jacques-n
Copy link
Contributor

This sounds like a good enhancement. You want to propose an update to the spec and proto representation? I might suggest using an enumeration instead of boolean just in case we need to introduce more variations later.

@ZJie1
Copy link
Contributor Author

ZJie1 commented May 6, 2022

This sounds like a good enhancement. You want to propose an update to the spec and proto representation? I might suggest using an enumeration instead of boolean just in case we need to introduce more variations later.

Sure, will send a PR.

@ZJie1
Copy link
Contributor Author

ZJie1 commented May 9, 2022

@jacques-n @mbasmanova Please help review #186

@cpcloud
Copy link
Contributor

cpcloud commented May 13, 2022

Closed by #186.

@cpcloud cpcloud closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jacques-n @cpcloud @mbasmanova @ZJie1