Rollup - improve loading time

[aminya]

• This makes the tool-bar load. reduces the actual loading time (if activation hook was not enabled)

Note: benchmark is done on top of #304

After rollup:

Before (considering no drawGutter):

For registering run the following:

npm install
npm run ppublish
apm publish patch

[ericcornelissen]

A few comments on the implementation below - do you have some numbers on how much this improves the loading time?

Also, is it the intention that the contents of dist/ end up in the repo at some point? If so, could you add a .gitattributes file with the following contents:

* text=auto

# don't diff machine generated files
lib/ -diff
package-lock.json -diff

[aminya]

A few comments on the implementation below - do you have some numbers on how much this improves the loading time?

It loads ~20ms faster (100->80). If we rollup the css files that gives another 30ms (I tried this). But for that we need to include ui-variables. If you are OK with that we can do that.

This is related to my other PR #299

I asked this question in the slack group but there was no answer

---

Is there a way to rollup less files in Atom. Because of @import "ui-variables";, I cannot do that. But if I copy a ui-variables.less file, the rollup works perfectly and I get huge speed ups.
Is there a such thing in less? Something like:
src: url("atom://defaulttheme/ui-variables.less") format("less");

This is the issue I created: xiaofuzi/rollup-plugin-less#30

---

Also, is it the intention that the contents of dist/ end up in the repo at some point? If so, could you add a .gitattributes file with the following contents:

Yes, we have to include dist folder. That is the limitation of apm. 😞

[ericcornelissen]

But for that we need to include ui-variables. If you are OK with that we can do that.

As per #299, that seems like a bad idea to me.

Yes, we have to include dist folder. That is the limitation of apm. 😞

Ow well, okay 👍

[aminya]

I added a script to rollup iconsets. That gives us another 10ms! 😃

[suda]

Nice! I agree that copying ui-variables is not ideal and with rolling up both code and iconsets, it might be enough.

[suda]

I'd also prefer the dist files to be in repo so all this dance of monkey patching the repo for apm publish could be removed in favor of simple npm version hook like this: https://github.com/particle-iot/particle-api-js/blob/master/package.json#L23

[aminya]

@suda The issue with only using git add is that once someone runs npm run build, those files will be tracked by git and will show up in the changelogs and commits (although being in gitignore).

This bash script circumvents that issue, and only adds the dist files through npm run ppublish, and after that git will not track them.

[aminya]

I made an npm package for ppublish script. https://github.com/aminya/build-commit
I will publish it tomorrow and using that instead of the bash script here.

[aminya]

@suda Could you merge this?