Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node version #63

Open
okdistribute opened this issue Oct 18, 2016 · 5 comments
Open

node version #63

okdistribute opened this issue Oct 18, 2016 · 5 comments
Labels

Comments

@okdistribute
Copy link
Member

does this require 0.12 or would it be easy enough to update deps so that it works with >=4.0.0? @substack

@morganrallen
Copy link
Collaborator

level has been updated, it's the only module that prevented building on Node 7.6.0

@rcsheets
Copy link
Member

I'd feel more confident about a node upgrade (and large changes generally) if we had a test suite.

@kenrestivo
Copy link

I added a github workflow for testing against modern nodejs, and, as expected, it did not go well https://github.com/kenrestivo/sudo-humans/actions/runs/728392688

@okdistribute
Copy link
Member Author

Change npm ci to npm install in your github action script and you'll get better progress. This app doesn't have a package-lock.json or shrinkwrap.json (this is what I gleaned from the debug output from github actions.)

@chughes87
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants