♻️(service-worker) improve SW registration and update handling

It is apparently a bad practice to add the version
number to the service worker file name.
This prevents the browser from properly updating
the service worker when a new version is available.

We improve the update handling by a more usual
pattern.

Author: AntoLC

CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to
   - ♿ add h1 for SR on 40X pages and remove alt texts #1438
   - ♿ update labels and shared document icon accessibility #1442
 - 🍱(frontend) Fonts GDPR compliants #1453
+- ♻️(service-worker) improve SW registration and update handling #1473
 
 ### Fixed
 

src/frontend/apps/impress/src/features/service-worker/hooks/useSWRegister.tsx

@@ -7,7 +7,7 @@ export const useSWRegister = () => {
       process.env.NEXT_PUBLIC_SW_DEACTIVATED !== 'true'
     ) {
       navigator.serviceWorker
-        .register(`/service-worker.js?v=${process.env.NEXT_PUBLIC_BUILD_ID}`)
+        .register(`/service-worker.js`)
         .then((registration) => {
           registration.onupdatefound = () => {
             const newWorker = registration.installing;
@@ -29,11 +29,13 @@ export const useSWRegister = () => {
           console.error('Service worker registration failed:', err);
         });
 
-      const currentController = navigator.serviceWorker.controller;
+      let refreshing = false;
       const onControllerChange = () => {
-        if (currentController) {
-          window.location.reload();
+        if (refreshing) {
+          return;
         }
+        refreshing = true;
+        window.location.reload();
       };
       navigator.serviceWorker.addEventListener(
         'controllerchange',