Unable to use ">" for getting direct child element. #71

why2000 · 2024-03-28T06:17:55Z

Describe the bug
With the getObject and getAllObject methods in querySelector.js, > symbol is removed in splitting, but never processed back and won't take effect. This causes all related Shadow.findElement(s) behaviors to be malfunctioning. See the following example:

To Reproduce
Steps to reproduce the behavior:

Consider a following DOM:

<html>
  <div id="a">
      <div id="b">
         <div id="c"></div>
      </div>
      <div id="d"></div>
  </div>
  <script src="querySelector.js"></script>
</html>

run getAllObject("div#a > div") in the console.
Actual result is [<div id="b">, <div id="c">, <div id="d">], but #c is not a direct child of #a

Expected behavior
Expected result should be [<div id="b">, <div id="d">]

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: MacOS 13.6.4
Browser: Chrome 123 / Safari 17.3.1

Additional context

shadow-automation-selenium/resources/querySelector.js

Line 245 in 3376e82

const multiLevelSelectors = splitByCharacterUnlessQuoted(selector, '>');

I don't understand why > is used to process multi-level DOM.
For functional, this is not needed at all, since without splitting, the script still works fine for piercing through multi-level shadow roots.
For performance, if we have to use some symbol to reduce the max size of possible elements cached in the allElements array, & would be a much better choice considering only one character is allowed in splitByCharacterUnlessQuoted.

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to use ">" for getting direct child element. #71

Unable to use ">" for getting direct child element. #71

why2000 commented Mar 28, 2024 •

edited

Loading

Unable to use ">" for getting direct child element. #71

Unable to use ">" for getting direct child element. #71

Comments

why2000 commented Mar 28, 2024 • edited Loading

why2000 commented Mar 28, 2024 •

edited

Loading