Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching DNS records are too greedy #78

Closed
davesbell opened this issue Jan 15, 2025 · 0 comments · Fixed by #82 · May be fixed by #79
Closed

Searching DNS records are too greedy #78

davesbell opened this issue Jan 15, 2025 · 0 comments · Fixed by #82 · May be fixed by #79

Comments

@davesbell
Copy link

I have a domain example.com

I have DNS records in the zones:
example.com
test.example.com

I have the following DNS record defined in netbox:

a-test.example.com

This causes two DNS records to be created.

2025-01-15T11:37:03 [6191755264] INFO NetboxSource[netbox] zone example.com. record added: Rr<a-test, A, 300, 127.0.0.1

2025-01-15T10:46:19 [6143684608] INFO NetboxSource[netbox] zone test.example.com. record added: Rr<a-, A, 300, 127.0.0.1

davesbell added a commit to davesbell/octodns-netbox that referenced this issue Jan 15, 2025
mochipon added a commit that referenced this issue Jan 20, 2025
- Add explicit check for apex records (fqdn == zone.name)
- Use fqdn.endswith(f".{zone.name}") for more precise suffix matching
  (fix #78)
- Skip records that do not match either condition to avoid duplicates
mochipon added a commit that referenced this issue Jan 20, 2025
- Add explicit check for apex records (fqdn == zone.name)
- Use fqdn.endswith(f".{zone.name}") for more precise suffix matching
  (fix #78)
- Skip records that do not match either condition to avoid duplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant