-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated DescriptiveParallelContributor model #532
Comments
no occurences found in DROs or Collections, using property_existence*.rb reports from #4245 |
Correction: there are lots of EMPTY occurrences of parallelContributor ... |
So does that mean this is un-removable? |
@justinlittman I think we could remove it by making it optional, omitable, and changing the default to nil. Then we can rewrite any/all descriptive metadata that has |
I don't think the cost of always putting in empty arrays should be "we can never omit an array property from the model." |
reran reports today; still no non-empty values for parallelContributor for collections or DROs. starting work on PR to (from JCoyne:)
|
DescriptiveParallelContributor class is marked deprecated: https://github.com/sul-dlss/cocina-models/blob/main/lib/cocina/models/descriptive_parallel_contributor.rb#L5
https://github.com/sul-dlss/cocina-models/blob/main/openapi.yml#552
Can it be removed?
Arcadia says "parallelContributor was never in use"
Steps
NOTE that this is the only thing marked deprecated in the cocina-models
openapi.yml
fileThe text was updated successfully, but these errors were encountered: