-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whisper options in speech-to-text job #1432
Comments
@edsu @peetucket The options that diverge from the default are the following.
|
Yeah, we could just alter the parameters that are different from the default, or just specify as much as we want (even if default) to be sure it stays as is if the defaults change. |
I'm not sure we want our settings to stay the same if the defaults change. I say this, because the options significance is very often opaque, and we are largely relying on OpenAI to decide what the best settings are. Hopefully we can get to a place where updating the version of whisper can be adequately tested so we aren't taking one step forward and two steps back when it comes to the quality of results, cf. #23 |
Ok, i'll update so only those settings that deviate from the default are set |
In the Whisper Pilot we did some testing to try to determine the best options to run Whisper with. The results were summarized in this doc.
We need to ensure that these options are sent to the speech-to-text service, since it does whatever it is told to do, and otherwise uses default values:
These options are currently set in https://github.com/sul-dlss/common-accessioning/blob/main/config/settings.yml#L71-L76
We may want to only specify the options that diverge from the default options. Or we could explicitly set all of them.
The text was updated successfully, but these errors were encountered: