Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss "Code Snippet" modal by clicking outside modal #1452

Open
mapninja opened this issue Dec 13, 2024 · 2 comments
Open

Dismiss "Code Snippet" modal by clicking outside modal #1452

mapninja opened this issue Dec 13, 2024 · 2 comments

Comments

@mapninja
Copy link

Currently, use the X of esc key to exit "Code Snippet" modal (and perhaps others). Many users, myself included, expect the modal to be dismissed if you click outside the modal and on the page it is superimposed on. Might not be possible for accessibility reasons, but if it is, it would be nice to add this behavior.

@dnoneill
Copy link
Contributor

Since we are using the blacklight modal for this feature I am going to suggest we fix this in blacklight that way all our apps can get the benefits of this feature.

@dnoneill
Copy link
Contributor

dnoneill commented Jan 9, 2025

should be closed with projectblacklight/blacklight#3489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants