Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Share link section to Share dialog #988

Closed
4 tasks done
ggeisler opened this issue May 17, 2019 · 3 comments
Closed
4 tasks done

Add Share link section to Share dialog #988

ggeisler opened this issue May 17, 2019 · 3 comments
Assignees
Labels

Comments

@ggeisler
Copy link
Contributor

ggeisler commented May 17, 2019

Part of #986.

The Share link section is intended to look something like:

Screen Shot 2019-05-16 at 5 33 22 PM

@jkeck
Copy link
Contributor

jkeck commented Jun 6, 2019

@ggeisler / @jvine WRT this task:

Add a label "Share link URL" for the textfield, but make it screenreader-only.

Is putting an aria-label on the <input /> reasonable? That's what MUI example does for the input w/o a visible label.

@jvine
Copy link

jvine commented Jun 6, 2019

Huh. I’d have said yes off the bat, but then I found this: https://www.powermapper.com/tests/screen-readers/labelling/input-text-aria-label/

Sigh. Should we be more robust in this one instance, or remain consistent with MUI? Leaning toward the latter I think. Gary?

@ggeisler
Copy link
Contributor Author

ggeisler commented Jun 6, 2019

I suspect we might have more than one instance of this in the future (i.e., search panel might have an input with hidden label) but not sure that really helps make a decision. From that web page JV found it looks like the support for the aria-label support is improving and fails in pretty limited cases, so I'd be comfortable sticking with the MUI approach.

@jkeck jkeck closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants