Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VkCreateDevice requests unavailable features ( support for Intel ARC ) #41

Open
mjtaryma opened this issue Aug 22, 2024 · 2 comments
Open

Comments

@mjtaryma
Copy link

VkCreateDevice called by RTGL is requesting features that are not supported by the Intel ARC. This causes a premature crash due to the call failing.
Those features seem to be not critical ( Disabling those features enables gzdoom-rt and prboom-plus-rt on ARC A770 ).

Here is the list:
VkPhysicalDeviceFeatures.shaderStorageImageMultisample
VkPhysicalDeviceFeatures.shaderFloat64
VkPhysicalDeviceFeatures.shaderResourceMinLod

Previous call to vkGetPhysicalDeviceFeatures2 returns properly and provides the right data to the application.
Fix options:

  1. Disable those features in hard-coded list in VulkanDevice_Init.cpp
  2. OR VkPhysicalDeviceFeatures obtained through vkGetPhysicalDeviceFeatures2 should be used for device creation.
@SharkyRawr
Copy link

Thanks for this, I made a fork with your changes and minor fixes to get CI running again (outdated VulkanSDK download URL gets 404). Action artifacts are available and this RayTracedGL1.dll works as a drop-in replacment for Half-Life Raytraced on my Arc A770.

@cdozdil
Copy link

cdozdil commented Sep 2, 2024

Just debugged and disabled same features and got it working, should have checked here first 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants