Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of this project #195

Open
MrWook opened this issue May 6, 2023 · 3 comments
Open

Future of this project #195

MrWook opened this issue May 6, 2023 · 3 comments

Comments

@MrWook
Copy link
Collaborator

MrWook commented May 6, 2023

I am not working at sumcumo anymore and i don't find the time nor the desire to work on something that i don't use anymore.

For vue3 there is an awesome library https://github.com/Vuepic/vue-datepicker which is in active development and should have all features from this library. I know that it is quite heavy with 43.3kB gzipped but it has even more features than this this library.

@mst101 if you want to maintain this library and keep pushing forward we could try to get you the access rights for it from the company. As you invested a lot of time in it already i published the 5.0.0 version and merged the vue3 integration after the newly published version

@MrWook MrWook pinned this issue May 6, 2023
@mst101
Copy link
Contributor

mst101 commented Jun 9, 2023

Hi @MrWook!

I'm sorry to hear you no longer wish to maintain this project and fully understand that you might like to invest your efforts elsewhere. Thank you for the work you have done; I appreciate the time you have spent in reviewing my code. I wish you all the very best in your new job!

Your message has prompted me to consider whether this project still has any merit... No-one wants to spend time on something that is not worthwhile!

So, I did some research into the multitude of Vue 3 datepickers out there.

I, for one, think it's important that any component worthy of being a replacement for <input type="date"> should be fully keyboard navigable. I realise I may be in a minority given that many of the datepickers I looked into only offer flawed or partial keyboard support - and almost half offer no keyboard support at all! But perhaps this is because this functionality is actually quite hard to implement?!

See the comparison here: https://vue3-datepickers.netlify.app

At just 27.14 kB of code (or 16.11 kB post-minification), I think our datepicker has its merits. It does one job and does it well. [The one you mentioned is 77.21 kB once you include its dependencies and it has poor keyboard support].

I don't know if anyone at @sum.cumo agrees and/or would be interested in taking on the role of maintaining the project? Perhaps you could ask? I'd certainly be happy to continue contributing, provided someone else is able to take on your role.

I've already fixed a few minor bugs in the latest version as well as:

  • Speeding up build times from 45 secs to approx 5 seconds
  • Converting the project to es6 modules
  • Adding the e2e tests to Github actions
  • Updating the Cleave.js and Vee-Validate integrations (this is currently causing a peer-dependency issue in v5.0 as the old version of vee-validate requires Vue 2.30)
  • Updating the build settings and the docs
  • Adding a dark mode (also for the docs)

I will upload my PRs in due course in the hope that someone will be able to have a look!

As for future development, this might include:

  • Converting the project to TypeScript
  • Making use of the Composiiton API to further reduce bundle size by extracting unwanted functionality

That said, if the consensus is to put the project to sleep, then so be it - I'll spend my time on other things!

Thanks again - and I hope to hear back from @sum.cumo in due course.

@brandonburkett
Copy link

@mst101 Did you end up taking it over? We are upgrading to Vue3 and this datepicker has served us well in Vue2!

@mst101
Copy link
Contributor

mst101 commented Aug 16, 2023

Hi @brandonburkett. I'm happy to continue contributing to the project, but don't want to take it on all by myself. There's a lot to be said for someone else reviewing your code / sharing ideas etc.

I'm super busy over the next few weeks, but it would be nice to hear from someone at sumcumo. @MrWook - have you been able to speak to anyone there? Or could you provide me with a contact? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants