Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx_builder does not handle decred consistently #14

Open
prestwich opened this issue May 3, 2018 · 2 comments
Open

tx_builder does not handle decred consistently #14

prestwich opened this issue May 3, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@prestwich
Copy link
Member

Sometimes it uses make_decred, sometimes it checks if the network is set to decred.

It should uniformly check if the network is set to decred.

@prestwich prestwich added enhancement New feature or request good first issue Good for newcomers labels May 3, 2018
@prestwich
Copy link
Member Author

I can't remember if I left the make_decred pattern on purpose as a convenience

@drmoog
Copy link

drmoog commented May 21, 2018

make_decred_input() is only called by the unit tests, so I suspect so. make_decred_witness is called within make_witness_input_and_witness() however, after checking network is set to decred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants