chore: raise minimum node version to 20+ (#2707)

sirineJ · web-flow · commit f8016ebe2460 · 2024-10-08T18:15:57.000+02:00
* chore: raise minimum node version to 20+

* fix: Intl RangeError exception

* chore: update @types/node

* chore: add changeset
diff --git a/.changeset/heavy-chairs-repeat.md b/.changeset/heavy-chairs-repeat.md
@@ -0,0 +1,13 @@
+---
+"@sumup-oss/stylelint-plugin-circuit-ui": major
+"@sumup-oss/eslint-plugin-circuit-ui": major
+"next-app": major
+"@sumup-oss/design-tokens": major
+"@sumup-oss/circuit-ui": major
+"@sumup-oss/cna-template": major
+"@sumup-oss/astro-template-circuit-ui": major
+"@sumup-oss/remix-template-circuit-ui": major
+"@sumup-oss/icons": major
+---
+
+Raised the minimum Node.js version to 20+.
diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml
@@ -16,10 +16,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup Node.js v18
+      - name: Setup Node.js v20
         uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
           cache: 'npm'
 
       - name: Install dependencies
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [18, 20]
+        node: [20, 22]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
diff --git a/.github/workflows/templates.yml b/.github/workflows/templates.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       # https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
       matrix:
-        node: [18, 20]
+        node: [20, 22]
         template: [astro, nextjs, remix]
         include:
           - template: astro
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-lts/hydrogen
+lts/iron
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -32,7 +32,7 @@ We appreciate pull requests (PRs) for smaller changes and bug fixes. For larger
 
 ### Prerequisites
 
-- [Node.js v18](https://nodejs.org/)
+- [Node.js v20](https://nodejs.org/)
 
 ### Installation
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
     "@sumup-oss/foundry": "^8.2.0",
     "@sumup-oss/eslint-plugin-circuit-ui": "^4.0.0",
     "@sumup-oss/stylelint-plugin-circuit-ui": "^2.0.0",
-    "@types/node": "^18.19.39",
+    "@types/node": "^22.7.4",
     "@vitest/coverage-v8": "^2.0.5",
     "audit-ci": "^7.1.0",
     "chromatic": "^11.7.1",
diff --git a/packages/circuit-ui/components/PhoneNumberInput/PhoneNumberInputService.ts b/packages/circuit-ui/components/PhoneNumberInput/PhoneNumberInputService.ts
@@ -46,7 +46,7 @@ export function mapCountryCodeOptions(
   const displayName = new Intl.DisplayNames(locale, { type: 'region' });
   return countryCodeOptions
     .map(({ code, country }) => {
-      const countryName = displayName.of(country);
+      const countryName = country ? displayName.of(country) : country;
       return {
         label: countryName ? `${countryName} (${code})` : code,
         value: code,
diff --git a/packages/circuit-ui/package.json b/packages/circuit-ui/package.json
@@ -71,7 +71,7 @@
     "@testing-library/react": "^16.0.1",
     "@testing-library/user-event": "^14.5.2",
     "@types/jest-axe": "^3.5.9",
-    "@types/node": "^18.19.39",
+    "@types/node": "^22.7.4",
     "@types/react": "^18.3.3",
     "@types/react-dates": "^21.8.6",
     "@types/react-dom": "^18.3.0",
@@ -102,6 +102,6 @@
     "react-dates": ">=21.8"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=20"
   }
 }
diff --git a/packages/design-tokens/package.json b/packages/design-tokens/package.json
@@ -36,7 +36,7 @@
     "prop-types": "^15.8.1"
   },
   "devDependencies": {
-    "@types/node": "^18.19.39",
+    "@types/node": "^22.7.4",
     "@types/prop-types": "^15.7.12",
     "tsx": "^4.16.5",
     "typescript": "^5.5.4"
diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -48,6 +48,6 @@
     "react": ">=16.0.0 <19.0.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=20"
   }
 }
diff --git a/templates/nextjs/README.md b/templates/nextjs/README.md
@@ -10,7 +10,7 @@ A [create-next-app template](https://nextjs.org/docs/api-reference/create-next-a
 
 ## 💻 Prerequisites
 
-- You should have **Node.js** installed at a version equal to or above **`v18.0.0`**.
+- You should have **Node.js** installed at a version equal to or above **`v20.0.0`**.
 
 ## ✨ Setting up a new Circuit UI + Next.js project
 
diff --git a/templates/nextjs/template/.nvmrc b/templates/nextjs/template/.nvmrc
@@ -1 +1 @@
-lts/hydrogen
+lts/iron
diff --git a/templates/nextjs/template/package.json b/templates/nextjs/template/package.json
@@ -31,7 +31,7 @@
     "@testing-library/user-event": "^14.5.2",
     "@types/jest": "^29.5.12",
     "@types/jest-axe": "^3.5.9",
-    "@types/node": "^18.19.39",
+    "@types/node": "^22.7.4",
     "@types/react": "^18.3.3",
     "@types/react-dom": "^18.3.0",
     "eslint-config-next": "^14.2.5",
diff --git a/templates/remix/package.json b/templates/remix/package.json

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,6 @@`
`48`	`48`	`"react": ">=16.0.0 <19.0.0"`
`49`	`49`	`},`
`50`	`50`	`"engines": {`
`51`		`- "node": ">=18"`
	`51`	`+ "node": ">=20"`
`52`	`52`	`}`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,6 @@`
`38`	`38`	`"typescript-plugin-css-modules": "^5.1.0"`
`39`	`39`	`},`
`40`	`40`	`"engines": {`
`41`		`- "node": ">=18"`
	`41`	`+ "node": ">=20"`
`42`	`42`	`}`
`43`	`43`	`}`