fix(codegen): deserialize typed JSON responses instead of casting JsonDocument#31
Merged
fix(codegen): deserialize typed JSON responses instead of casting JsonDocument#31
Conversation
…nDocument Issue #30 reported `InvalidCastException` in `ReadersClient.List/ListAsync`. The generated SDK code parsed response content as `JsonDocument` and cast it to `ReadersListResponse`, which fails at runtime. Root cause: - response mode selection re-inferred type from raw response schema - for some inline/object responses it chose "json-document" - generated clients emitted `(T)(object)document` casts for typed responses Fix: - change response mode resolution to use the already resolved response type from resolveResponseType(...) - keep "json-document" mode only when `ResponseType` is `JsonDocument` - use normal JSON deserialization for typed responses Added regression test. Fixes: #30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #30 reported
InvalidCastExceptioninReadersClient.List/ListAsync. The generated SDK code parsed response content asJsonDocumentand cast it toReadersListResponse, which fails at runtime.Root cause:
(T)(object)documentcasts for typed responsesFix:
ResponseTypeisJsonDocumentAdded regression test.
Fixes: #30