Moving features to core #2
Replies: 2 comments
-
Thanks! Yes, I've been attempting to keep the changes factored into independent patches, so hopefully it'll be straightforward to split them apart as needed. For example, I recently learned of rust-lang # 78802, in which the work to move several of the things we need into core is already underway. In theory, once that's ready we can just drop 26ab235e542390969d676d00f30f2a989125ef92. |
Beta Was this translation helpful? Give feedback.
-
Yes. However I still see two issues with rust-lang # 78802: A) The way you currently implement the IpAddr and co. types is plattform depended. If they are actually moved into core, I am almost certain, that they will be plattform independendly defined. B) This can only be merged after rust-lang#78802 is. |
Beta Was this translation helpful? Give feedback.
-
Great work you are doing. I noticed that in this branch, you do two things simultaniously:
std
tocore
oralloc
rustix
.I am not sure if it really beneficial to persue both of these in the same commit. Maybe it would be better to propose all change of target 1 in seperate commits (in case there are none allready) and restrict to only target 2 here. The only disadvantage I see is, that one must ensure that
rustix
types should not be exposed to the end user directly, to ensure that we can savely substitute them by theircore
equivalent if it gets created.Beta Was this translation helpful? Give feedback.
All reactions