Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User service #5

Merged
merged 4 commits into from
May 1, 2020
Merged

User service #5

merged 4 commits into from
May 1, 2020

Conversation

sungly
Copy link
Owner

@sungly sungly commented Apr 26, 2020

No description provided.

@sungly sungly requested a review from rocellaj April 26, 2020 16:57
Copy link
Collaborator

@rocellaj rocellaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was wondering, why not create a user service class and put all those functions inside? you wont need the index.ts to do all your exports? and export your class in the same file

export new UserService()

@sungly sungly merged commit e2a004a into master May 1, 2020
@sungly sungly deleted the user-service branch May 1, 2020 14:10
sungly pushed a commit that referenced this pull request May 1, 2020
# 1.0.0 (2020-05-01)

### Bug Fixes

* **package.json:** Fix bin in package.json ([56789b5](56789b5))

### Features

* **deployment:** Add Circleci ([e619ebd](e619ebd))
* **user-cmds:** Added more user service commands ([#5](#5)) ([e2a004a](e2a004a))
* **user-service:** Cognito user service ([#4](#4)) ([69abfa2](69abfa2))
sungly pushed a commit that referenced this pull request May 2, 2020
# 1.0.0 (2020-05-02)

### Bug Fixes

* **circleci:** Fixed npm auth cirleci ([f504f09](f504f09))
* **license:** Add MIT license ([b5d75e8](b5d75e8))
* **package.json:** Add publish config ([7ebd64c](7ebd64c))
* **package.json:** Fix bin in package.json ([56789b5](56789b5))
* **version:** Revert to version 1.0.0 ([16025ba](16025ba))

### Features

* **deployment:** Add Circleci ([e619ebd](e619ebd))
* **user-cmds:** Added more user service commands ([#5](#5)) ([e2a004a](e2a004a))
* **user-service:** Cognito user service ([#4](#4)) ([69abfa2](69abfa2))
* **version:** version bump ([859cfee](859cfee))
@sungly
Copy link
Owner Author

sungly commented May 2, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sungly sungly added the released label May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants