Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_full should roundtrip with history_prompt #161

Closed
netshade opened this issue Apr 26, 2023 · 3 comments
Closed

output_full should roundtrip with history_prompt #161

netshade opened this issue Apr 26, 2023 · 3 comments

Comments

@netshade
Copy link

The output_full argument of generate_audio seems to indicate that the returned dictionary of contexts ( including semantic_prompt) should be able to be used in future calls to generate_audio. However, it seems that methods that receive a history_prompt argument assume that the argument will always be a string referring to a file path where the returned value has been saved.

It seems that any method that receives a history_prompt should also check to see if the argument is an ndarray, as a common case for passing along context here would be breaking up an input text into multiple segments, in which case it would be desirable to include the prior context that was just generated to bias the next segment's output. ( Please note I don't have a very deep understanding of the use of history_prompt, so if I misunderstand its usage, I would love to be corrected )

@gkucsko
Copy link
Contributor

gkucsko commented Apr 26, 2023

yea, you have to first save it as save_as_prompt and then pass the filepath of the npz to the generate function. admittedly probably not the best choice of api contracts 😆 will put on the list to simplify at some point

@netshade
Copy link
Author

Are you open to a PR for this?

@gkucsko
Copy link
Contributor

gkucsko commented May 11, 2023

sure ya! closing for inactivity since it's not really an issue per se

@gkucsko gkucsko closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants