Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

First pass at code update: compatible with Sunpy 0.4 and other fixes #40

Open
aringlis opened this issue Feb 26, 2014 · 2 comments
Open

Comments

@aringlis
Copy link
Member

I've updated the code and tested it with a set of data files already in my possession. Tests were not exhaustive, but I'm able to run the code from start to finish.

Main changes:

  • updated code to reflect SunPy 0.4, particularly changes to the map API
  • fixes to coordinate transformations (thanks @ayshih)
  • renamed the main files to be more sensible and consistent
  • Updated the docstrings and the code comments
  • Added saving of some output products (right now, model maps of the detected wavefront, in HPC coordinates).

There's still plenty of cleanup to do. Known bugs off the top of my head:

  • persistence map function in aware_utils is broken
  • The use_pickle keyword doesn't work - should always be None at the moment
@ayshih
Copy link
Member

ayshih commented Feb 26, 2014

If you haven't already, can you go through the diff for (unmerged) PR #36 by hand and make sure that all fixes by @hayesla have been captured? Since there are whitespace differences, it's easier to look at the diff with those ignored:

https://github.com/sunpy/eitwave/pull/36/files?w=1

@aringlis
Copy link
Member Author

Will do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants