Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way of setting .data #779

Closed
Cadair opened this issue Nov 6, 2024 · 0 comments · Fixed by #795
Closed

Add a way of setting .data #779

Cadair opened this issue Nov 6, 2024 · 0 comments · Fixed by #795
Milestone

Comments

@Cadair
Copy link
Member

Cadair commented Nov 6, 2024

Describe the feature

I frequently have the case when working with DKIST data that I want to in-place compute the dask array, i.e. this:

spatial_avg = visp.rebin((-1, 1, -1), ).squeeze()
spatial_avg._data = spatial_avg.data.compute()

it would be nice if I didn't have to use ._data.

Proposed solution

Add a setter for .data which validates the new array is the same shape as the old array.

@Cadair Cadair added this to the 2.3.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant