Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Upstream Infrastructure for SPICE Analysis #176

Open
DanRyanIrish opened this issue Jan 4, 2021 · 6 comments
Open

Required Upstream Infrastructure for SPICE Analysis #176

DanRyanIrish opened this issue Jan 4, 2021 · 6 comments

Comments

@DanRyanIrish
Copy link
Member

DanRyanIrish commented Jan 4, 2021

To support tools for performing instrument-specific spectral analysis on SPICE data, the following generalized infrastructure must be developed/improved with the following priority:

Functionality Use Case Package Equivalent/Generalized Infrastructure Open Issue/PR
Fast Non-linear Fitting Fitting spectral line in all pixels astropy Parallelizing non-linear fitting astropy#3670, astropy#10985
Update sunraster for ndcube 2.0 Increase code stability sunraster sunraster#177
Superpixel with method option, e.g. mean, sum etc. Increase signal-to-noise by degrading spatial, spectral of temporal resolution ndcube resampling an NDCube ndcube#155, ndcube#290
Arithmetic operations Subtract background ndcube and/or astropy Arithmetic operations astropy#11176
@ebuchlin
Copy link

ebuchlin commented Apr 4, 2023

Some of these issues have been closed: #177, sunpy/ndcube#155 as done, astropy/astropy#10985 as end of experiment.

@wtbarnes
Copy link
Member

wtbarnes commented Apr 4, 2023

The last line "arithmetic operations" has also been completed as of sunpy/ndcube#541

@DanRyanIrish
Copy link
Member Author

Superpixelling is now possible with ndcube v 2.1.1 via the NDCube.rebin method. (sunpy/ndcube#450). So it seems the only outstanding item is better fitting support in astropy.

@Cadair
Copy link
Member

Cadair commented Apr 5, 2023

the only outstanding item is better fitting support in astropy

Trivial 🤦

@nabobalis
Copy link
Contributor

the only outstanding item is better fitting support in astropy

Trivial facepalm

You best fix it and soon.

@Cadair
Copy link
Member

Cadair commented Apr 5, 2023

I have written up this: astropy/astropy#14610 to summarise what's in my head today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants