Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid mapping the same MMIO pages multiple times. #325

Open
todo bot opened this issue Jun 13, 2019 · 0 comments
Open

Avoid mapping the same MMIO pages multiple times. #325

todo bot opened this issue Jun 13, 2019 · 0 comments
Assignees
Labels
todo 🗒️ Created by the todo bot

Comments

@todo
Copy link

todo bot commented Jun 13, 2019

Currently, if we need to map distinct MMIO regions sharing the same page, we do multiple mapping. This is wasteful of address space, which is a relatively scarce resource.
It might be a good idea to make an MMIO manager that hands out references to the same mapping (with different offsets) when a single page is shared.


// TODO: Avoid mapping the same MMIO pages multiple times.
// BODY: Currently, if we need to map distinct MMIO regions sharing the
// BODY: same page, we do multiple mapping. This is wasteful of address
// BODY: space, which is a relatively scarce resource.
// BODY:
// BODY: It might be a good idea to make an MMIO manager that hands out
// BODY: references to the same mapping (with different offsets) when
// BODY: a single page is shared.
if address.floor() != (address + 8).floor() {
panic!("Weird MMIO.")
}


This issue was generated by todo based on a TODO comment in 8012637 when #304 was merged. cc @roblabla.
@todo todo bot assigned roblabla Jun 13, 2019
@todo todo bot added the todo 🗒️ Created by the todo bot label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo 🗒️ Created by the todo bot
Projects
None yet
Development

No branches or pull requests

1 participant