Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fminf in compiler-builtins for soft-float #382

Open
todo bot opened this issue Jul 20, 2019 · 1 comment
Open

Missing fminf in compiler-builtins for soft-float #382

todo bot opened this issue Jul 20, 2019 · 1 comment
Assignees
Labels
project-libuser Related to the libuser status-upstream Blocked by an upstream bug todo 🗒️ Created by the todo bot

Comments

@todo
Copy link

todo bot commented Jul 20, 2019

See rust-lang/rust#62729.
As a workaround, we include the functions in libuser for now.


// TODO: Missing fminf in compiler-builtins for soft-float
// BODY: See https://github.com/rust-lang/rust/issues/62729.
// BODY:
// BODY: As a workaround, we include the functions in libuser for now.
/// Workaround rust-lang/rust#62729
#[no_mangle]
#[doc(hidden)]
pub extern "C" fn fminf(x: f32, y: f32) -> f32 {
libm::fminf(x, y)
}


This issue was generated by todo based on a TODO comment in 8b10070 when #377 was merged. cc @roblabla.
@todo todo bot assigned roblabla Jul 20, 2019
@todo todo bot added the todo 🗒️ Created by the todo bot label Jul 20, 2019
@roblabla roblabla added project-libuser Related to the libuser status-upstream Blocked by an upstream bug labels Jul 20, 2019
@roblabla
Copy link
Member

roblabla commented Jun 7, 2020

This got partially fixed by 0fd9a9e

However, it's still not fixed upstream. Instead we now use a fork of compiler-builtins that implements soft-float functions through a feature. This is suboptimal for a bunch of reasons (most importantly, the use of a feature instead of a target-feature makes this hard to upstream). Thus, I'm leaving this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-libuser Related to the libuser status-upstream Blocked by an upstream bug todo 🗒️ Created by the todo bot
Projects
None yet
Development

No branches or pull requests

1 participant