Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 not supported #70

Closed
MrAw3som3 opened this issue Mar 16, 2024 · 2 comments
Closed

Laravel 11 not supported #70

MrAw3som3 opened this issue Mar 16, 2024 · 2 comments

Comments

@MrAw3som3
Copy link

MrAw3som3 commented Mar 16, 2024

Hey there @sunspikes and the other contributors,
first and foremost thank you for this great package.

In my free time today I wanted to wrap my head around updating my projects to Laravel 11 and one of them is using clamav-validator. In this specific project the package is the only one that prevents me from upgrading, so I thought I would ask nicely for this simple change to be made.

I looked at the commit enabling Laravel 10 support by @ashleyshenton and it was "just" updating the composer dependencies.

To not come off as lazy, demanding or unprepared I did my fair share: Cloned this project, updated the composer.json to use the necessary versions of the conflicting packages, implemented it as a local package in my project and tested if anything breaks. I am glad that it still works like a charm for me in my - now - Laravel 11 application.

"illuminate/support": "~5.0 || ^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0 || ^11.0",
"illuminate/validation": "~5.0 || ^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0 || ^11.0"

We just need to update these to lines in the composer.json, like the time Laravel 10 support was implemented.

Any heroes out there?

@sunspikes
Copy link
Owner

Thanks, just merged: #71

@mweber-ion2s
Copy link

Thank you very much for the fast reaction :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants