Merge pull request #153 from supabase-community/fix/remove-required-key

fix: make download key optional
supabase · Sep 28, 2023 · d0c47c7 · d0c47c7
2 parents 9b227ce + fc93662
commit d0c47c7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/storage3/_async/file_api.py b/storage3/_async/file_api.py
@@ -187,7 +187,7 @@ async def create_signed_urls(
         """
         json = {"paths": paths, "expiresIn": str(expires_in)}
         if options.get("download"):
-            json.update({"download": options["download"]})
+            json.update({"download": options.get("download")})
 
         response = await self._request(
             "POST",

diff --git a/storage3/_sync/file_api.py b/storage3/_sync/file_api.py
@@ -187,7 +187,7 @@ def create_signed_urls(
         """
         json = {"paths": paths, "expiresIn": str(expires_in)}
         if options.get("download"):
-            json.update({"download": options["download"]})
+            json.update({"download": options.get("download")})
 
         response = self._request(
             "POST",

diff --git a/storage3/types.py b/storage3/types.py
@@ -67,7 +67,7 @@ class URLOptions(TypedDict, total=False):
     transform: TransformOptions
 
 
-class CreateSignedURLsOptions(TypedDict):
+class CreateSignedURLsOptions(TypedDict, total=False):
     download: Union[str, bool]