fix: generate signup link should not error #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Apr 3, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Apr 3, 2024
🤖 I have created a release *beep* *boop* --- ## [2.146.0](v2.145.0...v2.146.0) (2024-04-03) ### Features * add custom sms hook ([#1474](#1474)) ([0f6b29a](0f6b29a)) * forbid generating an access token without a session ([#1504](#1504)) ([795e93d](795e93d)) ### Bug Fixes * add cleanup statement for anonymous users ([#1497](#1497)) ([cf2372a](cf2372a)) * generate signup link should not error ([#1514](#1514)) ([4fc3881](4fc3881)) * move all EmailActionTypes to mailer package ([#1510](#1510)) ([765db08](765db08)) * refactor mfa and aal update methods ([#1503](#1503)) ([31a5854](31a5854)) * rename from CustomSMSProvider to SendSMS ([#1513](#1513)) ([c0bc37b](c0bc37b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 8535912117Details
💛 - Coveralls |
dagingaa
added a commit
to dagingaa/cli
that referenced
this pull request
Apr 22, 2024
GoTrue version 2.145.0 has a bug where generating a signup link will fail with "user_not_found", which was fixed in 2.146.0 (supabase/auth#1514). Since 2.145.0 is locked in the CLI, we can't get the bug fix out. This PR updates the image to 2.149.0 which is the most recent version as of 2024-04-22 so the signup link generation works again.
This was referenced Apr 22, 2024
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Fixes an error introduced in supabase#1377 where generating a signup link for a new user results in a "User with this email not found" error ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.146.0](supabase/auth@v2.145.0...v2.146.0) (2024-04-03) ### Features * add custom sms hook ([supabase#1474](supabase#1474)) ([0f6b29a](supabase@0f6b29a)) * forbid generating an access token without a session ([supabase#1504](supabase#1504)) ([795e93d](supabase@795e93d)) ### Bug Fixes * add cleanup statement for anonymous users ([supabase#1497](supabase#1497)) ([cf2372a](supabase@cf2372a)) * generate signup link should not error ([supabase#1514](supabase#1514)) ([4fc3881](supabase@4fc3881)) * move all EmailActionTypes to mailer package ([supabase#1510](supabase#1510)) ([765db08](supabase@765db08)) * refactor mfa and aal update methods ([supabase#1503](supabase#1503)) ([31a5854](supabase@31a5854)) * rename from CustomSMSProvider to SendSMS ([supabase#1513](supabase#1513)) ([c0bc37b](supabase@c0bc37b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Fixes an error introduced in supabase#1377 where generating a signup link for a new user results in a "User with this email not found" error ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.146.0](supabase/auth@v2.145.0...v2.146.0) (2024-04-03) ### Features * add custom sms hook ([supabase#1474](supabase#1474)) ([0f6b29a](supabase@0f6b29a)) * forbid generating an access token without a session ([supabase#1504](supabase#1504)) ([795e93d](supabase@795e93d)) ### Bug Fixes * add cleanup statement for anonymous users ([supabase#1497](supabase#1497)) ([cf2372a](supabase@cf2372a)) * generate signup link should not error ([supabase#1514](supabase#1514)) ([4fc3881](supabase@4fc3881)) * move all EmailActionTypes to mailer package ([supabase#1510](supabase#1510)) ([765db08](supabase@765db08)) * refactor mfa and aal update methods ([supabase#1503](supabase#1503)) ([31a5854](supabase@31a5854)) * rename from CustomSMSProvider to SendSMS ([supabase#1513](supabase#1513)) ([c0bc37b](supabase@c0bc37b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? * Fixes an error introduced in supabase#1377 where generating a signup link for a new user results in a "User with this email not found" error ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.146.0](supabase/auth@v2.145.0...v2.146.0) (2024-04-03) ### Features * add custom sms hook ([supabase#1474](supabase#1474)) ([0f6b29a](supabase@0f6b29a)) * forbid generating an access token without a session ([supabase#1504](supabase#1504)) ([795e93d](supabase@795e93d)) ### Bug Fixes * add cleanup statement for anonymous users ([supabase#1497](supabase#1497)) ([cf2372a](supabase@cf2372a)) * generate signup link should not error ([supabase#1514](supabase#1514)) ([4fc3881](supabase@4fc3881)) * move all EmailActionTypes to mailer package ([supabase#1510](supabase#1510)) ([765db08](supabase@765db08)) * refactor mfa and aal update methods ([supabase#1503](supabase#1503)) ([31a5854](supabase@31a5854)) * rename from CustomSMSProvider to SendSMS ([supabase#1513](supabase#1513)) ([c0bc37b](supabase@c0bc37b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.