Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linkedin_oidc provider error #1534

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: linkedin_oidc provider error #1534

merged 1 commit into from
Apr 15, 2024

Conversation

omerhochman
Copy link
Contributor

@omerhochman omerhochman commented Apr 14, 2024 •
edited
Loading

What kind of change does this PR introduce?

Fixes #1533

What is the current behavior?

Attempting to signInWithOAuth with linkedin_iodc provider results in error 500

What is the new behavior?

Attempting to signInWithOAuth with linkedin_iodc results in a successful login

Additional context

Error from Supabase Auth Logs:
oidc: id token issued by a different provider, expected \"https://www.linkedin.com\" got \"https://www.linkedin.com/oauth\"

@omerhochman omerhochman requested a review from a team as a code owner April 14, 2024 12:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8679759194

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.179%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/provider/linkedin_oidc.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8658928835: 0.0%
Covered Lines: 8060
Relevant Lines: 12366
💛 - Coveralls

@J0
Copy link
Contributor

J0 commented Apr 15, 2024 •
edited
Loading

Thanks! We'll test it out and get back to you. On the off chance do you happen to know if there was any announcement by LinkedIn about this change?

Oh hm site looks like it's been there for a while. Perhaps the enforcement was recent.

@omerhochman
Copy link
Contributor Author

I am not aware of any LinkedIn announcements.
All I know is that supabase signInWithOAuth with linkedin_iodc provider stopped working for us a couple of days ago.

@J0
Copy link
Contributor

J0 commented Apr 15, 2024

Thanks! Sorry to hear about the downtime - we'll do our best to get everyone up and running asap. I've tested that this patch works as expected - thank for filing the fix!

@J0 J0 merged commit 4f5e8e5 into supabase:master Apr 15, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
J0 added a commit that referenced this pull request Apr 15, 2024
@J0
Revert "fix: linkedin_oidc provider error (#1534)"
53faca5 
This reverts commit 4f5e8e5.
@J0 J0 mentioned this pull request Apr 15, 2024
Merged
J0 added a commit that referenced this pull request Apr 15, 2024
@J0
fix: revert patch for linkedin_oidc provider error (#1535)
58ef4af 
Reverts #1534

Doesn't seem to work as expected. Directly testing against the API by
calling `https://localhost:9999/?provider=linkedin_oidc will return a
404 error.
@Daniel-Alamezie
Copy link

is this now fixed? I still seem to be getting the same error

@kangmingtay kangmingtay mentioned this pull request Apr 15, 2024
Merged
kangmingtay added a commit that referenced this pull request Apr 15, 2024
@kangmingtay
fix: update linkedin issuer url (#1536)
10d6d8b 
## What kind of change does this PR introduce?
* Linkedin introduced a breaking change by changing the issuer url in
their
discover document from `https://linkedin.com` to
`https://linkedin.com/oauth`

* Fixes #1533, #1534,
[#22711](https://github.com/orgs/supabase/discussions/22711),
[#22708](https://github.com/orgs/supabase/discussions/22708)

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
@kangmingtay
Copy link
Member

@Daniel-Alamezie the fix is here -#1536 but it will take awhile for us to roll it out to the hosted platform - can you please open a ticket at https://supabase.help if you need this urgently?

kangmingtay pushed a commit that referenced this pull request Apr 15, 2024
@github-actions
chore(master): release 2.149.0 (#1532)
dd4f0e0 
🤖 I have created a release *beep* *boop*
---


##
[2.149.0](v2.148.0...v2.149.0)
(2024-04-15)


### Features

* refactor generate accesss token to take in request
([#1531](#1531))
([e4f2b59](e4f2b59))


### Bug Fixes

* linkedin_oidc provider error
([#1534](#1534))
([4f5e8e5](4f5e8e5))
* revert patch for linkedin_oidc provider error
([#1535](#1535))
([58ef4af](58ef4af))
* update linkedin issuer url
([#1536](#1536))
([10d6d8b](10d6d8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
J0 added a commit that referenced this pull request Apr 15, 2024
@J0
fix: support both postgres and http hooks
991ffa2 
Combination of multiple commits. More context below:

Fixes #1533

Attempting to signInWithOAuth with linkedin_iodc provider results in
error 500

Attempting to signInWithOAuth with linkedin_iodc results in a successful
login

Error from Supabase Auth Logs:
`oidc: id token issued by a different provider, expected
\"https://www.linkedin.com\" got \"https://www.linkedin.com/oauth\"`

fix: revert patch for linkedin_oidc provider error (#1535)

Reverts #1534

Doesn't seem to work as expected. Directly testing against the API by
calling `https://localhost:9999/?provider=linkedin_oidc will return a
404 error.

fix: update linkedin issuer url (#1536)

* Linkedin introduced a breaking change by changing the issuer url in
their
discover document from `https://linkedin.com` to
`https://linkedin.com/oauth`

* Fixes #1533, #1534,
[#22711](https://github.com/orgs/supabase/discussions/22711),
[#22708](https://github.com/orgs/supabase/discussions/22708)

Please link any relevant issues here.

Feel free to include screenshots if it includes visual changes.

Add any other context or screenshots.

chore(master): release 2.149.0 (#1532)

:robot: I have created a release *beep* *boop*
---

[2.149.0](v2.148.0...v2.149.0)
(2024-04-15)

* refactor generate accesss token to take in request
([#1531](#1531))
([e4f2b59](e4f2b59))

* linkedin_oidc provider error
([#1534](#1534))
([4f5e8e5](4f5e8e5))
* revert patch for linkedin_oidc provider error
([#1535](#1535))
([58ef4af](58ef4af))
* update linkedin issuer url
([#1536](#1536))
([10d6d8b](10d6d8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Revert "Merge branch 'master' into j0/allow_postgres_and_http_on_extensibility_point"

This reverts commit 4311d7e, reversing
changes made to 32fd777.
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@omerhochman
fix: linkedin_oidc provider error (supabase#1534)
9e1c294 
## What kind of change does this PR introduce?

Fixes supabase#1533

## What is the current behavior?

Attempting to signInWithOAuth with linkedin_iodc provider results in
error 500

## What is the new behavior?

Attempting to signInWithOAuth with linkedin_iodc results in a successful
login

## Additional context

Error from Supabase Auth Logs:
`oidc: id token issued by a different provider, expected
\"https://www.linkedin.com\" got \"https://www.linkedin.com/oauth\"`
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@J0
fix: revert patch for linkedin_oidc provider error (supabase#1535)
62eda78 
Reverts supabase#1534

Doesn't seem to work as expected. Directly testing against the API by
calling `https://localhost:9999/?provider=linkedin_oidc will return a
404 error.
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay
fix: update linkedin issuer url (supabase#1536)
4a1b684 
## What kind of change does this PR introduce?
* Linkedin introduced a breaking change by changing the issuer url in
their
discover document from `https://linkedin.com` to
`https://linkedin.com/oauth`

* Fixes supabase#1533, supabase#1534,
[#22711](https://github.com/orgs/supabase/discussions/22711),
[#22708](https://github.com/orgs/supabase/discussions/22708)

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.149.0 (supabase#1532)
a11327a 
🤖 I have created a release *beep* *boop*
---


##
[2.149.0](supabase/auth@v2.148.0...v2.149.0)
(2024-04-15)


### Features

* refactor generate accesss token to take in request
([supabase#1531](supabase#1531))
([e4f2b59](supabase@e4f2b59))


### Bug Fixes

* linkedin_oidc provider error
([supabase#1534](supabase#1534))
([4f5e8e5](supabase@4f5e8e5))
* revert patch for linkedin_oidc provider error
([supabase#1535](supabase#1535))
([58ef4af](supabase@58ef4af))
* update linkedin issuer url
([supabase#1536](supabase#1536))
([10d6d8b](supabase@10d6d8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@omerhochman @LashaJini
fix: linkedin_oidc provider error (supabase#1534)
4e007b4 
## What kind of change does this PR introduce?

Fixes supabase#1533

## What is the current behavior?

Attempting to signInWithOAuth with linkedin_iodc provider results in
error 500

## What is the new behavior?

Attempting to signInWithOAuth with linkedin_iodc results in a successful
login

## Additional context

Error from Supabase Auth Logs:
`oidc: id token issued by a different provider, expected
\"https://www.linkedin.com\" got \"https://www.linkedin.com/oauth\"`
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@J0 @LashaJini
fix: revert patch for linkedin_oidc provider error (supabase#1535)
dfc9968 
Reverts supabase#1534

Doesn't seem to work as expected. Directly testing against the API by
calling `https://localhost:9999/?provider=linkedin_oidc will return a
404 error.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @LashaJini
fix: update linkedin issuer url (supabase#1536)
bfe66a2 
## What kind of change does this PR introduce?
* Linkedin introduced a breaking change by changing the issuer url in
their
discover document from `https://linkedin.com` to
`https://linkedin.com/oauth`

* Fixes supabase#1533, supabase#1534,
[#22711](https://github.com/orgs/supabase/discussions/22711),
[#22708](https://github.com/orgs/supabase/discussions/22708)

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.149.0 (supabase#1532)
b860a4c 
🤖 I have created a release *beep* *boop*
---


##
[2.149.0](supabase/auth@v2.148.0...v2.149.0)
(2024-04-15)


### Features

* refactor generate accesss token to take in request
([supabase#1531](supabase#1531))
([e4f2b59](supabase@e4f2b59))


### Bug Fixes

* linkedin_oidc provider error
([supabase#1534](supabase#1534))
([4f5e8e5](supabase@4f5e8e5))
* revert patch for linkedin_oidc provider error
([supabase#1535](supabase#1535))
([58ef4af](supabase@58ef4af))
* update linkedin issuer url
([supabase#1536](supabase#1536))
([10d6d8b](supabase@10d6d8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@omerhochman @LashaJini
fix: linkedin_oidc provider error (supabase#1534)
ad86c17 
## What kind of change does this PR introduce?

Fixes supabase#1533

## What is the current behavior?

Attempting to signInWithOAuth with linkedin_iodc provider results in
error 500

## What is the new behavior?

Attempting to signInWithOAuth with linkedin_iodc results in a successful
login

## Additional context

Error from Supabase Auth Logs:
`oidc: id token issued by a different provider, expected
\"https://www.linkedin.com\" got \"https://www.linkedin.com/oauth\"`
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@J0 @LashaJini
fix: revert patch for linkedin_oidc provider error (supabase#1535)
f894860 
Reverts supabase#1534

Doesn't seem to work as expected. Directly testing against the API by
calling `https://localhost:9999/?provider=linkedin_oidc will return a
404 error.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@kangmingtay @LashaJini
fix: update linkedin issuer url (supabase#1536)
8f512e4 
## What kind of change does this PR introduce?
* Linkedin introduced a breaking change by changing the issuer url in
their
discover document from `https://linkedin.com` to
`https://linkedin.com/oauth`

* Fixes supabase#1533, supabase#1534,
[#22711](https://github.com/orgs/supabase/discussions/22711),
[#22708](https://github.com/orgs/supabase/discussions/22708)

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.149.0 (supabase#1532)
3c3a771 
🤖 I have created a release *beep* *boop*
---


##
[2.149.0](supabase/auth@v2.148.0...v2.149.0)
(2024-04-15)


### Features

* refactor generate accesss token to take in request
([supabase#1531](supabase#1531))
([e4f2b59](supabase@e4f2b59))


### Bug Fixes

* linkedin_oidc provider error
([supabase#1534](supabase#1534))
([4f5e8e5](supabase@4f5e8e5))
* revert patch for linkedin_oidc provider error
([supabase#1535](supabase#1535))
([58ef4af](supabase@58ef4af))
* update linkedin issuer url
([supabase#1536](supabase#1536))
([10d6d8b](supabase@10d6d8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using oauth with provider linkedin_oidc - Error getting user profile from external provider
5 participants
@omerhochman @coveralls @J0 @Daniel-Alamezie @kangmingtay