feat: send over user in SendSMS Hook instead of UserID #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8782486531Details
💛 - Coveralls |
hf
reviewed
Apr 22, 2024
hf
reviewed
Apr 22, 2024
hf
reviewed
Apr 22, 2024
hf
approved these changes
Apr 22, 2024
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
hf
pushed a commit
that referenced
this pull request
Apr 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([#1541](#1541)) ([1cb4f96](1cb4f96)) * add timeout middleware ([#1529](#1529)) ([f96ff31](f96ff31)) * allow for postgres and http functions on each extensibility point ([#1528](#1528)) ([348a1da](348a1da)) * merge provider metadata on link account ([#1552](#1552)) ([bd8b5c4](bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([#1551](#1551)) ([d4d743c](d4d743c)) ### Bug Fixes * return error if session id does not exist ([#1538](#1538)) ([91e9eca](91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? We align convention with `SendEmail` and send over a user to avoid having the user make an additional `getUser` call. Also allows access to `app_metadata` and `user_metadata` which would be useful for internationalization where you may want the locale of the user to determine which template to send. We also introduce a `PhoneData` struct through which we can introduce any potential phone related fields. This struct currently lives under the `hooks` package as there is no `phone` package currently and introducing one might require a significant refactor. Importing it as as is under `api` package would cause a circular dependency between `hooks` and `api` packages. --------- Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](supabase/auth@v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([supabase#1541](supabase#1541)) ([1cb4f96](supabase@1cb4f96)) * add timeout middleware ([supabase#1529](supabase#1529)) ([f96ff31](supabase@f96ff31)) * allow for postgres and http functions on each extensibility point ([supabase#1528](supabase#1528)) ([348a1da](supabase@348a1da)) * merge provider metadata on link account ([supabase#1552](supabase#1552)) ([bd8b5c4](supabase@bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([supabase#1551](supabase#1551)) ([d4d743c](supabase@d4d743c)) ### Bug Fixes * return error if session id does not exist ([supabase#1538](supabase#1538)) ([91e9eca](supabase@91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? We align convention with `SendEmail` and send over a user to avoid having the user make an additional `getUser` call. Also allows access to `app_metadata` and `user_metadata` which would be useful for internationalization where you may want the locale of the user to determine which template to send. We also introduce a `PhoneData` struct through which we can introduce any potential phone related fields. This struct currently lives under the `hooks` package as there is no `phone` package currently and introducing one might require a significant refactor. Importing it as as is under `api` package would cause a circular dependency between `hooks` and `api` packages. --------- Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](supabase/auth@v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([supabase#1541](supabase#1541)) ([1cb4f96](supabase@1cb4f96)) * add timeout middleware ([supabase#1529](supabase#1529)) ([f96ff31](supabase@f96ff31)) * allow for postgres and http functions on each extensibility point ([supabase#1528](supabase#1528)) ([348a1da](supabase@348a1da)) * merge provider metadata on link account ([supabase#1552](supabase#1552)) ([bd8b5c4](supabase@bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([supabase#1551](supabase#1551)) ([d4d743c](supabase@d4d743c)) ### Bug Fixes * return error if session id does not exist ([supabase#1538](supabase#1538)) ([91e9eca](supabase@91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? We align convention with `SendEmail` and send over a user to avoid having the user make an additional `getUser` call. Also allows access to `app_metadata` and `user_metadata` which would be useful for internationalization where you may want the locale of the user to determine which template to send. We also introduce a `PhoneData` struct through which we can introduce any potential phone related fields. This struct currently lives under the `hooks` package as there is no `phone` package currently and introducing one might require a significant refactor. Importing it as as is under `api` package would cause a circular dependency between `hooks` and `api` packages. --------- Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.150.0](supabase/auth@v2.149.0...v2.150.0) (2024-04-25) ### Features * add support for Azure CIAM login ([supabase#1541](supabase#1541)) ([1cb4f96](supabase@1cb4f96)) * add timeout middleware ([supabase#1529](supabase#1529)) ([f96ff31](supabase@f96ff31)) * allow for postgres and http functions on each extensibility point ([supabase#1528](supabase#1528)) ([348a1da](supabase@348a1da)) * merge provider metadata on link account ([supabase#1552](supabase#1552)) ([bd8b5c4](supabase@bd8b5c4)) * send over user in SendSMS Hook instead of UserID ([supabase#1551](supabase#1551)) ([d4d743c](supabase@d4d743c)) ### Bug Fixes * return error if session id does not exist ([supabase#1538](supabase#1538)) ([91e9eca](supabase@91e9eca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We align convention with
SendEmailand send over a user to avoid having the user make an additionalgetUsercall. Also allows access toapp_metadataanduser_metadatawhich would be useful for internationalization where you may want the locale of the user to determine which template to send.We also introduce a
PhoneDatastruct through which we can introduce any potential phone related fields. This struct currently lives under thehookspackage as there is nophonepackage currently and introducing one might require a significant refactor. Importing it as as is underapipackage would cause a circular dependency betweenhooksandapipackages.