fix: return proper error if sms rate limit is exceeded #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9787183147Details
💛 - Coveralls |
J0
approved these changes
Jul 4, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Jul 4, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([#1646](#1646)) ([a518505](a518505)) * check for empty aud string ([#1649](#1649)) ([42c1d45](42c1d45)) * return proper error if sms rate limit is exceeded ([#1647](#1647)) ([3c8d765](3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@kangmingtay it is not clear how to enjoy this fix. At first glance it seems that issue was related to a rate limit in sending sms. Im pretty sure we never hit our twilio limits, so is that a Supabase limit? If so, should we handle this on client with reference to #1629 or Supabase's retry is transparent to us? |
|
@kangmingtay can you also explain how this commit fixes issue #1629 ? |
|
@iosephmagno it fixes the issue because i was only able to reproduce #1629 when i exceeded the rate limit, and noticed that the auth service was returning a 5xx error rather than a 429. |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Fixes supabase#1629 * Previously, rate limit errors were being returned as an internal server error, which is incorrect. This PR checks for the underlying error type returned and ensures that rate limit errors are surfaced appropriately. ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](supabase/auth@v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([supabase#1646](supabase#1646)) ([a518505](supabase@a518505)) * check for empty aud string ([supabase#1649](supabase#1649)) ([42c1d45](supabase@42c1d45)) * return proper error if sms rate limit is exceeded ([supabase#1647](supabase#1647)) ([3c8d765](supabase@3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * Fixes supabase#1629 * Previously, rate limit errors were being returned as an internal server error, which is incorrect. This PR checks for the underlying error type returned and ensures that rate limit errors are surfaced appropriately. ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](supabase/auth@v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([supabase#1646](supabase#1646)) ([a518505](supabase@a518505)) * check for empty aud string ([supabase#1649](supabase#1649)) ([42c1d45](supabase@42c1d45)) * return proper error if sms rate limit is exceeded ([supabase#1647](supabase#1647)) ([3c8d765](supabase@3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? * Fixes supabase#1629 * Previously, rate limit errors were being returned as an internal server error, which is incorrect. This PR checks for the underlying error type returned and ensures that rate limit errors are surfaced appropriately. ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.1](supabase/auth@v2.155.0...v2.155.1) (2024-07-04) ### Bug Fixes * apply mailer autoconfirm config to update user email ([supabase#1646](supabase#1646)) ([a518505](supabase@a518505)) * check for empty aud string ([supabase#1649](supabase#1649)) ([42c1d45](supabase@42c1d45)) * return proper error if sms rate limit is exceeded ([supabase#1647](supabase#1647)) ([3c8d765](supabase@3c8d765)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.