fix: check password max length in checkPasswordStrength

[kangmingtay]

What kind of change does this PR introduce?

• Check if password exceeds max length in checkPasswordStrength

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

[coveralls]

Pull Request Test Coverage Report for Build 9986796684

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 3 of 6 (50.0%) changed or added relevant lines in 2 files are covered.
• 145 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.03%) to 58.0%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/api/admin.go	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
internal/api/token.go	63	72.79%
internal/models/user.go	82	76.25%

Totals
Change from base Build 9911056994:	-0.03%
Covered Lines:	8816
Relevant Lines:	15200

---

💛 - Coveralls

[J0]

I think one concern in the past was that adminCreateUser doesn't do a password check

I think it relies on models.NewUser to call GenerateFromPassword which then performs the check.

Let's ensure the validation check on password length for adminUserCreate is preserved before moving forward.

Otherwise looks good to me

[J0]

Ah my bad - tested and I realize bcrypt will still throw an error on this line
even if Auth does not explicitly throw an error. So it should be fine

[kangmingtay]

@J0 that's a good point, the admin create user error will return an error if the password length exceeds the max length but the error won't be obvious and is returned as a 500

i've updated the PR to wrap the error and return a bad request error instead