Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat empty string as nil in encrypted_password #1663

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Jul 17, 2024

Authenticate should treat empty string as nil, as both mean the same thing.

@hf hf requested a review from a team as a code owner July 17, 2024 15:25
@hf hf changed the base branch from release/2.155.0 to master July 17, 2024 15:28
@hf hf force-pushed the hf/fix-authenticate-empty-string branch from 39c37a9 to b48e0fa Compare July 17, 2024 15:31
@coveralls
Copy link

coveralls commented Jul 17, 2024

Pull Request Test Coverage Report for Build 9977136011

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 58.021%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/token.go 1 3 33.33%
internal/models/user.go 1 3 33.33%
Totals Coverage Status
Change from base Build 9911056994: -0.01%
Covered Lines: 8818
Relevant Lines: 15198

💛 - Coveralls

@kangmingtay kangmingtay merged commit f99286e into master Jul 17, 2024
2 checks passed
@kangmingtay kangmingtay deleted the hf/fix-authenticate-empty-string branch July 17, 2024 15:41
kangmingtay pushed a commit that referenced this pull request Jul 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.155.4](v2.155.3...v2.155.4)
(2024-07-17)


### Bug Fixes

* treat empty string as nil in `encrypted_password`
([#1663](#1663))
([f99286e](f99286e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
`Authenticate` should treat empty string as nil, as both mean the same
thing.
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.155.4](supabase/auth@v2.155.3...v2.155.4)
(2024-07-17)


### Bug Fixes

* treat empty string as nil in `encrypted_password`
([supabase#1663](supabase#1663))
([f99286e](supabase@f99286e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
`Authenticate` should treat empty string as nil, as both mean the same
thing.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.155.4](supabase/auth@v2.155.3...v2.155.4)
(2024-07-17)


### Bug Fixes

* treat empty string as nil in `encrypted_password`
([supabase#1663](supabase#1663))
([f99286e](supabase@f99286e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
`Authenticate` should treat empty string as nil, as both mean the same
thing.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.155.4](supabase/auth@v2.155.3...v2.155.4)
(2024-07-17)


### Bug Fixes

* treat empty string as nil in `encrypted_password`
([supabase#1663](supabase#1663))
([f99286e](supabase@f99286e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants