fix: remove server side cookie token methods #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
changed the title
J0
commented
Aug 27, 2024
Pull Request Test Coverage Report for Build 10588318197Details
💛 - Coveralls |
kangmingtay
approved these changes
Aug 27, 2024
|
Good catch, also removed the relevant test code in There's a |
kangmingtay
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [2.159.2](v2.159.1...v2.159.2) (2024-08-28) ### Bug Fixes * allow anonymous user to update password ([#1739](#1739)) ([2d51956](2d51956)) * hide hook name ([#1743](#1743)) ([7e38f4c](7e38f4c)) * remove server side cookie token methods ([#1742](#1742)) ([c6efec4](c6efec4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Remove set cookie tokens and clear cookie token methods as it looks like they aren't done server side. Task: https://www.notion.so/supabase/team-auth-113cb19144c1419ea5fb1d600281d959?p=ff083dad758e44ef9b4e230804e0fee7&pm=s
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.159.2](supabase/auth@v2.159.1...v2.159.2) (2024-08-28) ### Bug Fixes * allow anonymous user to update password ([supabase#1739](supabase#1739)) ([2d51956](supabase@2d51956)) * hide hook name ([supabase#1743](supabase#1743)) ([7e38f4c](supabase@7e38f4c)) * remove server side cookie token methods ([supabase#1742](supabase#1742)) ([c6efec4](supabase@c6efec4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Remove set cookie tokens and clear cookie token methods as it looks like they aren't done server side. Task: https://www.notion.so/supabase/team-auth-113cb19144c1419ea5fb1d600281d959?p=ff083dad758e44ef9b4e230804e0fee7&pm=s
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.159.2](supabase/auth@v2.159.1...v2.159.2) (2024-08-28) ### Bug Fixes * allow anonymous user to update password ([supabase#1739](supabase#1739)) ([2d51956](supabase@2d51956)) * hide hook name ([supabase#1743](supabase#1743)) ([7e38f4c](supabase@7e38f4c)) * remove server side cookie token methods ([supabase#1742](supabase#1742)) ([c6efec4](supabase@c6efec4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? Remove set cookie tokens and clear cookie token methods as it looks like they aren't done server side. Task: https://www.notion.so/supabase/team-auth-113cb19144c1419ea5fb1d600281d959?p=ff083dad758e44ef9b4e230804e0fee7&pm=s
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.159.2](supabase/auth@v2.159.1...v2.159.2) (2024-08-28) ### Bug Fixes * allow anonymous user to update password ([supabase#1739](supabase#1739)) ([2d51956](supabase@2d51956)) * hide hook name ([supabase#1743](supabase#1743)) ([7e38f4c](supabase@7e38f4c)) * remove server side cookie token methods ([supabase#1742](supabase#1742)) ([c6efec4](supabase@c6efec4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Remove set cookie tokens and clear cookie token methods as it looks like they aren't done server side.
Task: https://www.notion.so/supabase/team-auth-113cb19144c1419ea5fb1d600281d959?p=ff083dad758e44ef9b4e230804e0fee7&pm=s