fix: skip cleanup for non-2xx status #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12410628463Details
💛 - Coveralls |
J0
approved these changes
Dec 19, 2024
kangmingtay
force-pushed
the
km/fix-cleanup-logging
branch
from
ac4d7ea to
0c88646
Compare
hf
pushed a commit
that referenced
this pull request
Dec 23, 2024
🤖 I have created a release *beep* *boop* --- ## [2.165.1](v2.165.0...v2.165.1) (2024-12-19) ### Bug Fixes * check if session is nil ([#1873](#1873)) ([fd82601](fd82601)) * email_verified field not being updated on signup confirmation ([#1868](#1868)) ([483463e](483463e)) * handle user banned error code ([#1851](#1851)) ([a6918f4](a6918f4)) * Revert "fix: revert fallback on btree indexes when hash is unavailable" ([#1859](#1859)) ([9fe5b1e](9fe5b1e)) * skip cleanup for non-2xx status ([#1877](#1877)) ([f572ced](f572ced)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Dec 23, 2024
hf
pushed a commit
that referenced
this pull request
Dec 23, 2024
🤖 I have created a release *beep* *boop* --- ## [2.166.0](v2.165.0...v2.166.0) (2024-12-23) ### Features * switch to googleapis/release-please-action, bump to 2.166.0 ([#1883](#1883)) ([11a312f](11a312f)) ### Bug Fixes * check if session is nil ([#1873](#1873)) ([fd82601](fd82601)) * email_verified field not being updated on signup confirmation ([#1868](#1868)) ([483463e](483463e)) * handle user banned error code ([#1851](#1851)) ([a6918f4](a6918f4)) * Revert "fix: revert fallback on btree indexes when hash is unavailable" ([#1859](#1859)) ([9fe5b1e](9fe5b1e)) * skip cleanup for non-2xx status ([#1877](#1877)) ([f572ced](f572ced)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
ResponseWriteris a non-2xx codedatabaseCleanupto make it easier to test