feat: fix argon2 parsing and comparison #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
reviewed
Dec 24, 2024
kangmingtay
approved these changes
Dec 24, 2024
Pull Request Test Coverage Report for Build 12480774856Details
💛 - Coveralls |
J0
reviewed
Dec 24, 2024
J0
approved these changes
Dec 24, 2024
hf
pushed a commit
that referenced
this pull request
Dec 24, 2024
🤖 I have created a release *beep* *boop* --- ## [2.167.0](v2.166.0...v2.167.0) (2024-12-24) ### Features * fix argon2 parsing and comparison ([#1887](#1887)) ([9dbe6ef](9dbe6ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Super grateful for the quick turnaround on getting this through! Not to sound the slightest bit ungrateful, but is there guidance on how long to expect the problem to persist on my cloud hosted project? |
Rollout is underway. |
|
@hf thanks so much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argon2 parsing and comparison is broken in multiple ways:
ConstantTimeCompare. This Go API is awful as it returns 1 on equality (unlike all other comparison APIs that return 0) so it was missed.argon2.KeyandIDKeyaccept KiB as arguments (not bytes!) which caused all hashes to always be incorrect.Tests didn't catch this as they only tested for the positive case (which passed with flying colors).