Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve invalid channel error message returned #1908

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix: improve invalid channel error message returned #1908

merged 4 commits into from
Jan 15, 2025

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Jan 10, 2025 •
edited by hf
Loading

What kind of change does this PR introduce?

  • Improve error message around invalid channel error for phone auth. Only twilio and twilio verify support whatsapp as a valid channel.

@kangmingtay kangmingtay requested a review from a team as a code owner January 10, 2025 19:22
@coveralls
Copy link

coveralls commented Jan 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12773618798

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.435%
Totals Coverage Status
Change from base Build 12724630104: 0.0%
Covered Lines: 9814
Relevant Lines: 14998
💛 - Coveralls

hf
hf approved these changes Jan 11, 2025
View reviewed changes
internal/api/errors.go Outdated Show resolved Hide resolved
@kangmingtay @hf
chore: uppercase key terms
d9a27c9 
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
@kangmingtay kangmingtay enabled auto-merge (squash) January 13, 2025 20:10
@kangmingtay kangmingtay disabled auto-merge January 14, 2025 18:01
@hf hf self-requested a review January 15, 2025 09:26
@hf hf merged commit f72f0ee into master Jan 15, 2025
5 checks passed
@hf hf deleted the km/update-error-message branch January 15, 2025 10:18
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @coveralls @hf