fix: link password flag override (#3295)

sweatybridge · web-flow · commit 853bc969cbaa · 2025-03-15T07:03:02.000+08:00
diff --git a/cmd/link.go b/cmd/link.go
@@ -33,6 +33,8 @@ var (
 			if err := flags.LoadConfig(fsys); err != nil {
 				return err
 			}
+			// TODO: move this to root cmd
+			cobra.CheckErr(viper.BindPFlag("DB_PASSWORD", cmd.Flags().Lookup("password")))
 			return link.Run(ctx, flags.ProjectRef, fsys)
 		},
 	}
@@ -43,6 +45,5 @@ func init() {
 	linkFlags.StringVar(&flags.ProjectRef, "project-ref", "", "Project ref of the Supabase project.")
 	linkFlags.StringVarP(&dbPassword, "password", "p", "", "Password to your remote Postgres database.")
 	// For some reason, BindPFlag only works for StringVarP instead of StringP
-	cobra.CheckErr(viper.BindPFlag("DB_PASSWORD", linkFlags.Lookup("password")))
 	rootCmd.AddCommand(linkCmd)
 }

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,8 @@ var (`
`33`	`33`	`if err := flags.LoadConfig(fsys); err != nil {`
`34`	`34`	`return err`
`35`	`35`	`}`
	`36`	`+ // TODO: move this to root cmd`
	`37`	`+ cobra.CheckErr(viper.BindPFlag("DB_PASSWORD", cmd.Flags().Lookup("password")))`
`36`	`38`	`return link.Run(ctx, flags.ProjectRef, fsys)`
`37`	`39`	`},`
`38`	`40`	`}`
`@@ -43,6 +45,5 @@ func init() {`
`43`	`45`	`linkFlags.StringVar(&flags.ProjectRef, "project-ref", "", "Project ref of the Supabase project.")`
`44`	`46`	`linkFlags.StringVarP(&dbPassword, "password", "p", "", "Password to your remote Postgres database.")`
`45`	`47`	`// For some reason, BindPFlag only works for StringVarP instead of StringP`
`46`		`- cobra.CheckErr(viper.BindPFlag("DB_PASSWORD", linkFlags.Lookup("password")))`
`47`	`48`	`rootCmd.AddCommand(linkCmd)`
`48`	`49`	`}`